qt: minor improvements and bugfix #10366
Open
+26
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tooltips to the "New Channel" button so users understand why it is disabled and what it does when it is enabled.
Disable the `Submarine Payments` tab if the swap_manager is None (the wallet has no lightning support).
Disables the lightning related config options in the ConfirmTxDialog tools and shows an according tooltip if lightning is not available in the wallet. This should prevent confusion of users.
Also show the `Tools` text besides the preferences icon so it looks equal to the main window. Originally this was a followup part of spesmilo#10300 which got closed due to other reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor qt improvements and a bugfix for the submarine payments tab.
Adds tooltips to the "New Channel" button so users understand why it is
disabled and what it does when it is enabled.
Disable the
Submarine Paymentstab if the swap_manager is None (thewallet has no lightning support). This fixes an exception when opening the tab while not having lightning.
Disables the lightning related config options in the ConfirmTxDialog
tools and shows an according tooltip if lightning is not available in
the wallet. This should prevent confusion of users.
Also show the
Toolstext besides the preferences icon so it looks equal to the main window.Originally this was a followup part of qt: followup #10277: change icons depending on context #10300 which got closed for other reasons.